Model, Module, and Class Naming Reduction/Refactor #190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
v2/listen
for the PreRecorded client but Live client will stay onv1/listen
. This doesn't create a dependency on something that is shared between the two. (This will be cleaned up later... since there are some deprecated options exposed. Please see note below.)Live
,PreRecorded
,OnPrem
,Manage
, and soon to beAnalyze
... this removes the folder nameLive
from the class name, for exampleLiveTranscriptionResponse.cs
->TranscriptionResponse.cs
since the class is scoped in theLive/v1/TranscriptionResponse.cs
module.Manage
model. Since nearly every Manage API call requires a project ID (with the exception of project calls), we can reduce the name of classes for convenience. For example,GetProjectInvitesResponse
->InvitesResponse
andCreateProjectKeySchema
->KeySchema
. The likelihood of the API creating naming collision is low since they probably wont change, and even if they do, we can:DeepgramClientOptions
fromShared/v1
toAuthenticate/v1
. ThisAuthenticate/v1
can and will be shared withOnPrem
auth in a bit.DeepgramHttpClient
toEncapsulations
since the function of the classes within do exactly that, plus to be inline withAbstractions
name. For example, there is anHttpClientWrapper
class that just encapsulates the native .NET HttpClient.All unit tests pass with these updated names, modules, etc.
TODOs in subsequent PRs: